Add power-saver (SAV) option to RADEON_DPM_PERF*, RADEON_DPM_STATE* settings #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Your commit looks good to me. However, you need to add the new parameters to tlp.conf: I'm still wondering which parameter values you are actually using for all the profiles. Maybe you could just show |
Contributor
Author
|
This is my configuration > tlp-stat -c | grep RADEON
defaults.conf L0034: RADEON_DPM_PERF_LEVEL_ON_AC="auto"
/etc/tlp.conf L0387: RADEON_DPM_PERF_LEVEL_ON_BAT="auto"
/etc/tlp.conf L0388: RADEON_DPM_PERF_LEVEL_ON_SAV="low"
/etc/tlp.conf L0394: RADEON_DPM_STATE_ON_AC="performance"
/etc/tlp.conf L0395: RADEON_DPM_STATE_ON_BAT="battery"
/etc/tlp.conf L0396: RADEON_DPM_STATE_ON_SAV="battery" |
Owner
|
@SkajpCZ Now merged to main (commit messages edited). |
Owner
|
@SkajpCZ What I noticed only afterwards: the kernel docs for the amdgpu driver call the sysfile power_dpm_state behind RADEON_DPM_STATE_ON_ "a legacy interface and is only provided for backwards compatibility". TLP doesn't write anything in there anymore. The parameter can be removed entirely, right? Please show: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the code that i used as PoC for the power-saver setting for
RADEON_DPM_PERF*andRADEON_DPM_STATE*.It works the way I expected. When I have my laptop plugged in with power-saver - its set to power-saver. When i put balanced or performance it respects the _AC setting, also the same applies from battery.